Repository navigation
Conversation
|
@thuluxx is attempting to deploy a commit to the 10-mohan's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /register route destructured adminSecret from the request body and imported getAdminSecret, but never actually checked them — so any request with role: "admin" was granted admin privileges with no secret required.
This adds the missing check: registering with role: "admin" now requires a correct adminSecret matching getAdminSecret(), and returns 403 otherwise.
Verified manually:
Before the fix: role: "admin" alone → admin token issued
After the fix: no/wrong secret → 403 Invalid admin secret; correct secret → admin token issued as expected
Existing test suite (npm test) still passes.