feat(generator):add edit frames - #215
Open
cqhasy wants to merge 8 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Found one blocking integration issue in the frame-edit request path.
Verification: targeted Go tests for internal/module/generator, internal/handler, and internal/router pass. The focused frontend test could not start because this workspace has Node.js 20.20.2, while pnpm 11.5.0 requires Node.js 22.13 or newer.
Findings without inline locations
frontend/src/features/asset-editor/editor-generation-request.ts:34: High:edit_framesnow requiresparameters.animationIdandparameters.frameIds(run_manager.gorejects the request when either is missing), but this builder still sends the selected frames only astargetAssetPathsand reservesparametersfor the optional reference. Every inspector frame edit therefore reaches the API without the required fields and fails withframe ids are required for edit_frames(oranimation id is required). Please translate the selected animation/frame identities into the new parameter shape; also account for the backend expecting persisted numeric IDs rather than the current node IDs and zero-based indices.
6 tasks
cqhasy
force-pushed
the
feat/edit-frames
branch
from
August 14, 2026 07:28
5b165e8 to
1f20b14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Implement partial frame regeneration for generated animations.
The animation generation pipeline currently stores only processed frames after background removal and compression, which makes it difficult to regenerate specific frames while preserving temporal consistency.
This change introduces the foundation for frame-level regeneration by separating raw AI-generated frames from processed frames and supporting regeneration based on selected target frames and contextual frames.
The observable changes include:
Implementation Approach
RawURL: the original frame generated by the video model.ProcessedURL: the frame after background removal, resizing, compression, and other post-processing.TargetFramesinstead of relying only on a start/end range.Related Issue
Part of #214
Testing
Screenshots or Recording
Not applicable.
Risks and Follow-ups
Checklist