feat(ui-set): refine creation form workflow - #216
Open
JeremyD7 wants to merge 4 commits into
Open
Conversation
UI Set creation needs structured dimensions and ordered component input. Add canvas presets, component management, and local-only submission feedback. Keep generation requests disconnected while the backend workflow is pending.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Adding a component reset every component card to expanded. Update only affected expansion indexes when components are added or removed. Keep creators' collapsed component layout intact.
UI Set drafts carried a stale generic canvas size alongside structured dimensions. Derive the canvas size from dimensions when creating drafts and requests. Ensure UI Set request metadata remains internally consistent.
UI Set drafts gained stable component identities and centralized canvas constraints. Keep form defaults stable across renders while submitting schema-transformed data. Cover component editing, canvas selection, and local UI Set submission.
Contributor
Author
|
/review -claude |
1 similar comment
Contributor
Author
|
/review -claude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Implementation Approach
isCustomcomponent field and add localized UI Set labels and validation messages.Related Issue
Closes #208
Testing
pnpm.cmd exec vitest run src/features/generation/lib/asset-creation.test.ts src/i18n/resources.test.ts- passed.pnpm.cmd build- passed.Screenshots or Recordings
Not included.
Risks and Follow-ups
Checklist