Skip to content

fix: improve scenario dialogue closing and intent handling - #86

Merged
yydounai1234 merged 1 commit into
1024XEngineer:mainfrom
HansonL622:final-bugfix
Aug 13, 2026
Merged

fix: improve scenario dialogue closing and intent handling#86
yydounai1234 merged 1 commit into
1024XEngineer:mainfrom
HansonL622:final-bugfix

Conversation

@HansonL622

Copy link
Copy Markdown
Contributor

Summary

  • prevent duplicate closing responses by letting state advancement drive each scenario response exactly once
  • treat changed requests and declined optional topics as valid conversation progress
  • constrain scene endings to one short, natural in-role farewell without recap or learner evaluation
  • add focused frontend and backend regression coverage

Verification

  • npm run check:realtime-events
  • npm run build
  • backend targeted scenario dialogue tests: 15/15 passed

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in this review. The changed scenario prompt/state-machine behavior and realtime response handling were checked across code quality, performance, security, and documentation accuracy passes. Targeted verification passed: npm run check:realtime-events and ./mvnw -q -Dtest=ScenarioDialogueEventExtractorTest,ScenarioDialogueStateMachineTest,CustomSceneGeneratorTest test.

@yydounai1234 yydounai1234 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yydounai1234
yydounai1234 merged commit 13bc365 into 1024XEngineer:main Aug 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants