Skip to content

chore(history): preserve deferred read-only skeleton - #105

Merged
minorcell merged 7 commits into
1024XEngineer:mainfrom
xyh202131:feat/history-page
Aug 13, 2026
Merged

chore(history): preserve deferred read-only skeleton#105
minorcell merged 7 commits into
1024XEngineer:mainfrom
xyh202131:feat/history-page

Conversation

@xyh202131

@xyh202131 xyh202131 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

当前定位

History 当前保留只读页面和 WorkflowHistoryReader 接口骨架,不在 App 中注册路由,也不在项目导航暴露入口。

本次更新

  • 已同步最新 main
  • 修正陈旧说明:后端 PR feat(workflow-run): 实现执行记录 CRUD 服务与 API #176 已提供按 Project 分页查询 WorkflowRun 的接口。
  • 页面仍不伪造数据、localStorage 降级或额外 HTTP 路径。
  • 创建工作流必须先由正式用例取得真实 runId,再进入 /workflow-editor/:runId
  • 保留六节点工作流中“资产生成方式”的只读展示名称。

后续启用条件

  1. WorkflowRunStore 的真实适配器合并。
  2. App 将该 Store 装配为 History 的只读来源。
  3. 完成后再增加 History 路由和项目导航入口。

验证

  • History 页面测试:5 条通过。
  • TypeScript 类型检查、oxlint、格式检查通过。
  • 生产构建通过。

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
windup Ready Ready Preview Aug 10, 2026 5:57am

@xyh202131
xyh202131 marked this pull request as ready for review August 4, 2026 06:45

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review findings:

  • frontend/src/app/app.tsx: The new history page is not imported or registered in the app router. The README documents /projects/:projectId/history, but the current route table still only has /projects/:projectId and /projects/:projectId/assets, so that URL falls through to NotFoundPage and the page cannot be reached in the actual app.

Verification: attempted npm test -- src/pages/history -- --run, npm run typecheck, and npm run lint; all failed before running because the frontend command binaries (vitest, tsc, oxlint) were not executable/available in this checkout.

Comment thread frontend/src/pages/history/index.tsx Outdated
Comment thread frontend/src/pages/history/README.md Outdated
Comment thread frontend/src/pages/history/README.md Outdated
@xyh202131 xyh202131 changed the title feat(history): add project workflow history refactor(history): display persisted workflow node graphs Aug 8, 2026
@xyh202131 xyh202131 changed the title refactor(history): display persisted workflow node graphs chore(history): preserve deferred read-only skeleton Aug 8, 2026

@minorcell minorcell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码 review 通过:只读骨架不注册路由、零生产影响,节点状态派生 Run 状态的设计与 README 一致,测试覆盖派生/错误/空态。提醒:依赖的 #107(六节点契约)与 #176(WorkflowRun CRUD)已于 8/10 合并,README 与测试注释里的「#107 合并前」已过时,骨架可以推进接真实适配器并注册路由。

@minorcell
minorcell merged commit fa1d12e into 1024XEngineer:main Aug 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants