chore(history): preserve deferred read-only skeleton - #105
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
xyh202131
marked this pull request as ready for review
August 4, 2026 06:45
Contributor
There was a problem hiding this comment.
Review findings:
frontend/src/app/app.tsx: The new history page is not imported or registered in the app router. The README documents/projects/:projectId/history, but the current route table still only has/projects/:projectIdand/projects/:projectId/assets, so that URL falls through toNotFoundPageand the page cannot be reached in the actual app.
Verification: attempted npm test -- src/pages/history -- --run, npm run typecheck, and npm run lint; all failed before running because the frontend command binaries (vitest, tsc, oxlint) were not executable/available in this checkout.
This was referenced Aug 6, 2026
This was referenced Aug 6, 2026
xyh202131
force-pushed
the
feat/history-page
branch
from
August 8, 2026 08:05
270b027 to
882d37d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当前定位
History 当前保留只读页面和
WorkflowHistoryReader接口骨架,不在 App 中注册路由,也不在项目导航暴露入口。本次更新
main。runId,再进入/workflow-editor/:runId。后续启用条件
验证