Skip to content

refactor(account): consolidate account form state - #306

Open
fennoai[bot] wants to merge 1 commit into
mainfrom
fennoai/issue-263-1786671370
Open

refactor(account): consolidate account form state#306
fennoai[bot] wants to merge 1 commit into
mainfrom
fennoai/issue-263-1786671370

Conversation

@fennoai

@fennoai fennoai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • consolidate account profile state in a dedicated reducer
  • consolidate login security fields and submission state in a dedicated reducer
  • keep section switching cleanup explicit, including sensitive password fields
  • add reducer transition tests for refresh, save, validation, failure, and section changes

Verification

  • npm test -- src/pages/account/index.test.tsx src/pages/account/state.test.ts --configLoader runner
  • npm run typecheck
  • npm run lint
  • npm run format:check

Closes #263

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
windup Ready Ready Preview Aug 14, 2026 1:43am

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.69231% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
frontend/src/pages/account/index.tsx 79.41% 3 Missing and 4 partials ⚠️
frontend/src/pages/account/state.ts 88.88% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

fennoai[bot]

This comment was marked as outdated.

@minorcell
minorcell requested a review from huyanxius August 14, 2026 01:52
@minorcell

Copy link
Copy Markdown
Member

/review

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in this review.

Verified the focused account tests (13 passing), TypeScript typecheck, lint, and formatting check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(account): consolidate account form state management

1 participant