feat(quality-ledger): 生成成色与提示词版本落库 - #322
Open
johnnyzhang-eng wants to merge 1 commit into
Open
Conversation
引擎已算出 ActionQuality 但 executor 组装结果时整个丢掉,任务无条件 COMPLETED,无法回答改提示词有没有变好。 新增 subject_blobs(逐帧主体连通块计数,4-连通,不依赖 scipy)补上 motion_scale/dead_frames/loop_seam 测不出的多出一个主体这类病; 成色(含 subject_blobs)与 prompt_version 落进任务结果,只记账不判决, 交付/重试仍是下游按阈值决定。
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review conclusion
The quality-ledger path is coherent across the fixed diff: subject_blobs() is exported and measured on aligned delivery frames, ActionQuality and GeneratedAction carry the new required fields, and the executor/task repository preserve them through JSON persistence and read-back. The added calibration and orchestration tests cover the key connectivity boundaries and end-to-end accounting contract. I did not identify an actionable correctness or regression issue in the changed code.
Verification
git diff --checkpassed.python3 -m compileall -q packages testspassed.- Targeted pytest execution was unavailable because this environment does not provide
uvor the installed Pillow dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #311
改了什么
slicing/quality.py新增subject_blobs()(逐帧统计画面里"够大"的连通块数,4-连通游程并查集实现,不依赖 scipy)ports/__init__.py:ActionQuality加subject_blobs字段;GeneratedAction加prompt_version字段(均无默认值,逼调用方显式带出)prompt/__init__.py新增PROMPT_VERSION常量impl/character_generator.py的_assess()填上subject_blobs,generate()出参带上prompt_versionorchestrator/executor.py/model.py/task_repo.py:成色(dataclasses.asdict)与prompt_version落进任务结果并可反序列化读回test_subject_blobs.py(六种合成掩码校准连通性边界)+ 既有测试补齐新增字段的构造/端到端断言为什么
引擎已经算出成色(
ActionQuality),但executor组装结果时整个丢掉,任务无条件 COMPLETED——无法回答"上次改提示词到底有没有变好",也无法区分"每帧都一样的 walk"与"步态干净的 walk"。subject_blobs补的是motion_scale/dead_frames/loop_seam共同的盲区:三者都只看"帧与帧之间变了多少",一个稳定存在的额外主体(母版/提示词让引擎多画出一个角色)不影响它们任何一个读数。本 PR 只记账,不做判决——不因为成色差就置 FAILED,交付/重试仍是下游按阈值决定的产品决策。
怎么验证的
backend/下:uv run ruff check .— All checks passeduv run lint-imports— Contracts: 2 kept, 0 brokenuv run pytest -q— 689 passed, 14 skipped