Repository navigation
Make regional placement safe and repair deployment readiness - #1
Merged
Merged
Conversation
10thfloor
marked this pull request as ready for review
September 25, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller previously returned successful no-op triggers, could not bootstrap scale-up, and could apply unprotected scaling commands to the wrong app. This change makes a placement cycle aggregate regional traffic, reconcile the explicitly selected Fly app/process group, and execute bounded actions with protected regions, persistent cooldowns, atomic state, and recovery after uncertain failures.
It also requires bearer authentication, fixes recent-request measurement and configuration reloads, excludes credentials from build contexts, replaces runtime Poetry with hash-locked dependencies, packages the pinned Fly CLI, and repairs the Fly service address and container startup. The dashboard now shows read-only regional traffic without exposing its backend token, uses native Deno server rendering, and upgrades Remix/Vite/PostCSS to patched compatible releases. Obsolete compiled Python artifacts are removed. README and environment templates document dry-run setup, live prerequisites, persistence, and the single-controller operating model.
Validation: all six GitHub validation jobs passed on this commit, including Python 3.11/3.12 tests, the dashboard job, and all three image builds; deployment was skipped for this pull request. Locally, 177 backend tests pass on each Python version and 12 dashboard tests pass on Deno 2.9.7. Final patched images pass authenticated API, rendered dashboard, token privacy, cache-header, and graceful-shutdown checks; backend persistence, non-root execution, and IPv4/IPv6 access also passed. Fly operations in tests are mocked; no live app was changed.
Behavior changes: live mode requires explicit PLACER_TARGET_APP, PLACER_API_TOKEN, a protected region, and an existing stateless Fly Launch-managed process group. Fixed thresholds with temporal smoothing replace the broken moving threshold. Empty/malformed metrics, unhealthy/transitional Machines, and unrecoverable protected-region capacity constraints stop changes. Callers must schedule authenticated triggers; the service does not start a background scheduler.
Dependency assessment: the public manifest endpoint DoS is fixed in Remix 2.17.5. Registry auditing still reports conditional turbo-stream/router advisories and build-tool advisories: Single Fetch is disabled, routes do not use attacker-controlled navigation/error subtypes, and the affected build tools are outside the production request path. This change does not claim a vulnerability-free dependency tree.