Skip to content

State the provider-independent rule and the E2EE coverage rule in AGENTS.md - #228

Open
ai-13rac1 wants to merge 1 commit into
13rac1:mainfrom
ai-13rac1:agents-provider-agnostic
Open

ai-13rac1 wants to merge 1 commit into
13rac1:mainfrom
ai-13rac1:agents-provider-agnostic

Conversation

@ai-13rac1

Copy link
Copy Markdown
Contributor

Problem

AGENTS.md has no rule against code that compares a provider's name, and no rule for an endpoint that the provider's E2EE protocol does not support.

  • internal/proxy/proxy.go:1746 applies a rule to the two NEAR providers by name.
  • docs/api_support.md refuses NEAR audio transcription while E2EE is enabled, but no rule says that every provider must refuse an endpoint that its E2EE protocol does not support.

Change

  • AGENTS.md, new section "Provider-Independent Rules": only provider construction selects code by provider name. When one provider needs a rule, add a field that every provider sets, such as UsesTLSBinding, and apply the rule to every provider that sets it.
  • AGENTS.md, No Fallbacks: never send a request to an endpoint that the provider's E2EE protocol does not support while E2EE is enabled. To use such an endpoint, the user sets e2ee = false and adds e2ee_usable to allow_fail. The request then uses TLS, which attestation binds only for a provider that uses TLS binding.
  • .github/instructions/code-review.instructions.md: the same two rules as review checks.

Effect

Contributors and reviewers have one rule for provider-specific needs and one for unsupported E2EE endpoints. No code changes.

To verify

git diff origin/main...HEAD --stat
git diff origin/main...HEAD -- AGENTS.md .github/instructions/code-review.instructions.md

The first command lists only these two files. The second shows the added rules in both.

Point of discussion

Existing code compares provider names outside construction (internal/proxy/proxy.go lines 716, 1119, 1746 and 3262). These are violations of the first rule. Should they move to provider fields in a follow-up change, or should the rule list them as known exceptions until then?

Checklist

  • I added unit tests for new code and regression tests for fixed bugs.
  • make check passes.
  • For a major feature: make integration and make reports pass.
  • I updated the documentation that this change affects.

Code has applied rules to one provider by comparing its name, and
AGENTS.md had no rule for an endpoint that the provider's E2EE protocol
does not support. The first rule limits name checks to provider
construction and asks for a field that every provider sets. The second
rule refuses an unsupported endpoint while E2EE is enabled, and states
what the user sets to use it without E2EE. The code-review instructions
get the same two checks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@13rac1 13rac1 added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants