Repository navigation
Conversation
Code has applied rules to one provider by comparing its name, and AGENTS.md had no rule for an endpoint that the provider's E2EE protocol does not support. The first rule limits name checks to provider construction and asks for a field that every provider sets. The second rule refuses an unsupported endpoint while E2EE is enabled, and states what the user sets to use it without E2EE. The code-review instructions get the same two checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AGENTS.mdhas no rule against code that compares a provider's name, and no rule for an endpoint that the provider's E2EE protocol does not support.internal/proxy/proxy.go:1746applies a rule to the two NEAR providers by name.docs/api_support.mdrefuses NEAR audio transcription while E2EE is enabled, but no rule says that every provider must refuse an endpoint that its E2EE protocol does not support.Change
AGENTS.md, new section "Provider-Independent Rules": only provider construction selects code by provider name. When one provider needs a rule, add a field that every provider sets, such asUsesTLSBinding, and apply the rule to every provider that sets it.AGENTS.md, No Fallbacks: never send a request to an endpoint that the provider's E2EE protocol does not support while E2EE is enabled. To use such an endpoint, the user setse2ee = falseand addse2ee_usabletoallow_fail. The request then uses TLS, which attestation binds only for a provider that uses TLS binding..github/instructions/code-review.instructions.md: the same two rules as review checks.Effect
Contributors and reviewers have one rule for provider-specific needs and one for unsupported E2EE endpoints. No code changes.
To verify
The first command lists only these two files. The second shows the added rules in both.
Point of discussion
Existing code compares provider names outside construction (
internal/proxy/proxy.golines 716, 1119, 1746 and 3262). These are violations of the first rule. Should they move to provider fields in a follow-up change, or should the rule list them as known exceptions until then?Checklist
make checkpasses.make integrationandmake reportspass.