tau-bot: skip times the author marked as local - #602
Merged
Conversation
Contributor
|
Thank you for your contribution. Can you resubmit this PR with a signed commit? We cannot accept any contributions that haven't been signed |
"10:51 local time" means whatever the reader's clock says, not the author's, so converting it to their timezone is misleading. Add "local" / "local time" to the matcher and drop those matches up front so Tau-bot stays quiet. Closes 18F#533. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
c-tonneslan
force-pushed
the
fix/tau-bot-skip-local-time
branch
from
May 18, 2026 14:09
a27584f to
6cdfd34
Compare
Contributor
Author
|
Done, force-pushed with an SSH-signed commit. Also re-signed #603 the same way. Thanks! |
rahearn
requested changes
May 18, 2026
| "meeting at 9:00 local", | ||
| ]) { | ||
| message.event.text = text; | ||
| await handler(message); |
Contributor
There was a problem hiding this comment.
[suggestion] lets pull these two test cases into two separate it methods. That will ensure we know which test fails in the future and also address the lint error
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
…nneslan/charlie into fix/tau-bot-skip-local-time
Contributor
Author
|
Split into two. |
rahearn
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #533, when someone writes "10:51 local time" they mean "whatever the reader's clock says," not "10:51 in my timezone," so Tau-bot's translation is misleading there. Added
local/local timeto the matcher and filter those matches out before processing so Tau-bot stays quiet.Closes #533.