Conversation
changelog: Internal, Analytics, Upgrade Digital Analytics Program to v8.4 release
zachmargolis
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates to patch and use latest version of Digital Analytics Program (DAP) analytics script, v8.4.
In the newer version of the DAP script, they've addressed one of the biggest reasons for maintaining our own copy; namely, the leaking of variables into the global namespace, and the lack of aggressive minification on the built artifact. It could be worth considering to switch back to the hosted version to avoid the maintenance overhead of version upgrades, but I'd like to see asynchronous loading of the analytics scripts first (upstream PR at digital-analytics-program/gov-wide-code#121). There are other benefits to maintaining our own copy, outlined in #11097.
The newer version is slightly larger:
yarn && NODE_ENV=production yarn build && brotli-size public/packs/digital-analytics-program-*.digested.jsBefore: 6.79kb
After: 7.4kb
Diff: +0.61kb (+9%)
📜 Testing Plan
Run
yarn buildRepeat Testing Plan from #11097