fix: clear inherited admin password in smoke test - #34
Merged
zhengkunwang223 merged 1 commit intoSep 23, 2026
Merged
zhengkunwang223 merged 1 commit into
zhengkunwang223 merged 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change resolves the configuration conflict.
Review effort: Lite
Findings: None
What changed in this PR
Fixes the smoke test by clearing an inherited plaintext admin password before setting its generated hash.
Changes:
- Removes
LAYA_ADMIN_PASSWORDfrom the smoke-test environment.
| File | Summary |
|---|---|
scripts/smoke-real-model.py |
Prevents conflicting password environment settings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real-model smoke script generates its own temporary password hash. If
LAYA_ADMIN_PASSWORDis already exported, both password settings are present and configuration validation stops the script before it can run.Clear the inherited plaintext password before setting the smoke-test hash. This adds one line to
scripts/smoke-real-model.pyand only affects the smoke-test process.Validation: