Skip to content

fix: clear inherited admin password in smoke test - #34

Merged
zhengkunwang223 merged 1 commit into
1Panel-dev:mainfrom
jianneng-fit2cloud:codex/fix-smoke-password-env
Sep 23, 2026
Merged

zhengkunwang223 merged 1 commit into
1Panel-dev:mainfrom
jianneng-fit2cloud:codex/fix-smoke-password-env

Conversation

@jianneng-fit2cloud

Copy link
Copy Markdown
Contributor

The real-model smoke script generates its own temporary password hash. If LAYA_ADMIN_PASSWORD is already exported, both password settings are present and configuration validation stops the script before it can run.

Clear the inherited plaintext password before setting the smoke-test hash. This adds one line to scripts/smoke-real-model.py and only affects the smoke-test process.

Validation:

  • Reproduced the original configuration failure with an inherited plaintext password.
  • Verified configuration setup with absent, empty, plaintext, and hash-only password environments.
  • Existing backend suite: 5 passed.
  • Full model inference was not run because local model checkpoints are unavailable.

Copilot AI lite review requested due to automatic review settings September 23, 2026 09:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused change resolves the configuration conflict.

Review effort: Lite
Findings: None

What changed in this PR

Fixes the smoke test by clearing an inherited plaintext admin password before setting its generated hash.

Changes:

  • Removes LAYA_ADMIN_PASSWORD from the smoke-test environment.
File Summary
scripts/​smoke-real-model.py Prevents conflicting password environment settings.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@zhengkunwang223
zhengkunwang223 merged commit 934912b into 1Panel-dev:main Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants