Feature/alliance renewal#1
Merged
Merged
Conversation
reduce productivity when nuked update news modal adjust investment adjustproductivity balance fix productivity growth adjust again nerf investment reduce default gold
…mpts, translations, and tests - Implements alliance renewal and expiry functionality - Shows renewal prompt only for expiring alliances involving local player - Adds translations for all new alliance events (en/nl) - Updates EventsDisplay for correct prompts and messages - Adds AllianceExpireCheckExecution & AllianceExtensionExecution files - Adds unit test for AllianceExtensionExecution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This (1) helps prevent accidental attacks between allies when a renewal opportunity is missed
and (2) is still usefull when you missed the pre-expiration promt.
Discord username:
el_magico777
My 2nd ever PR and its a port from the first. Appreciate all tips to improve my work!