Upgrade Bonuses for units#100
Merged
Merged
Conversation
- Update submarine ghost structure to include ownerID. - Implement ghost rendering and clearing logic in UnitLayer. - Clear persisted settings in GameRenderer for new game resets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Research All Techs" game configuration option to both the host lobby and single player modals, and makes several improvements to unit rendering logic, particularly for submarines and interpolated units. The most important changes are grouped below by theme.
New Game Option: "Research All Techs"
researchAllTechsoption to bothHostLobbyModalandSinglePlayerModal, including UI checkbox, state management, and inclusion in game config serialization and deserialization. This allows hosts and single players to enable instant research of all technologies for the match. [1] [2] [3] [4] [5] [6] [7]resources/lang/en.json. [1] [2]Unit Rendering Logic Improvements
UnitLayerto better manage rendered units and ghosts, including new maps to track their state, improved update logic, and explicit handling of unit deactivation when units are removed. [1] [2] [3] [4]Interpolated Rendering for Shells and Warheads
ShellandMIRVWarheadunit types, using colored squares and segments to visually indicate their movement and relationship.UI and Graphics Consistency
Miscellaneous
Let me know if you have questions about any of these changes or want to dive deeper into the new rendering logic!