Diplomacy Tab#103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Declare War" feature to the game, expanding the diplomacy system and user interface. Players can now explicitly declare war on other players who are not currently allies or enemies, both through the radial menu and the new Diplomacy tab in the control panel. The backend supports this intent with schema updates and a new execution class, and the UI includes improved visual feedback and management tools for embargos. Below are the most important changes grouped by theme.
Gameplay & Diplomacy System:
DeclareWarIntentand corresponding execution logic, allowing players to declare war on others who are neither allies nor enemies. This includes schema updates, backend handling, and mutual war/aggression recording. [1] [2] [3] [4] [5] [6] [7] [8]GameRunnerand player interaction logic to expose thecanDeclareWarflag, ensuring the option is only available when appropriate.User Interface Enhancements:
ControlPanel2showing lists of players at war, allied, or neutral, and integrated embargo management buttons ("Embargo All" and "Remove All Embargos"). [1] [2] [3] [4] [5] [6]Gameplay Mechanics Updates:
Event Handling:
SendDeclareWarIntentEventand integrated it into the transport/event bus system for client-server communication. [1] [2] [3]Miscellaneous:
Let me know if you have questions about how the new Declare War feature works, or if you want to walk through the flow from UI to backend!