Unit Upgrades#94
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature that allows players to set default upgrade levels for combat units, similar to the existing structure upgrade settings. It removes the old "unit upgrade mode" logic and replaces it with a persistent, client-side modal for managing unit upgrade preferences. The build menu and underlying cost calculations are updated to respect these settings, and the UI now clearly displays the configured unit levels. The changes are grouped into feature additions, UI enhancements, and codebase cleanup.
Feature Additions:
UnitUpgradeSettingsModal(src/client/UnitUpgradeSettingsModal.ts), a persistent modal for configuring default upgrade levels for units. These settings are stored locally and capped per unit type.UI Enhancements:
build-level-chipelement, improving clarity for players. [1] [2] [3]UIStateand renderer logic to track and use client-side unit levels for rendering and interaction. [1] [2] [3]Codebase Cleanup:
ToggleUnitUpgradeModeEventfile, marking it for removal.Let me know if you want a walkthrough of how the new modal works or how the build menu now calculates and displays unit upgrade levels!