Fix Windows tag checkout result handling - #114
Merged
1lck merged 3 commits intoAug 17, 2026
Merged
Conversation
yangboxuan726
force-pushed
the
fix/windows-git-tag-checkout-result
branch
from
August 16, 2026 13:53
e891db7 to
3e44fbb
Compare
yangboxuan726
marked this pull request as ready for review
August 17, 2026 00:35
1lck
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
git_checkout_tagfrom the shared Core{ output, exitCode }result instead of always reporting success.Why
The Windows result adapter previously returned
success: truefor every tag checkout, so Git failures could be presented as successful and trigger a Git-changed event. The existingcheckoutTagAPI emits only when the adapted result is successful; propagating the real exit code restores that contract.Validation
bun test src/platform/core-result-adapter.test.ts(7 passed)bun test src/platform(21 passed)bun run typecheck./scripts/verify-windows-boundaries.ps1./scripts/build-windows.ps1 -Configuration Releasecargo test --manifest-path windows/tauri/src-tauri/Cargo.toml(32 passed)