feat(windows): start built-in Java LSP through the host - #120
Merged
Conversation
Open Java files on Windows with the shared Core Java provider instead of the extension marketplace. The host finds jdtls and a local JDK, then starts lsp.startServer with providerId java so definition and references can use the same session as macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jdtlsand a local JDK, then call shared Corelsp.startServerwithproviderId: "java".@Value, and bean injections withspring.index, and resolve those locations before falling back to the language server.No definition found.Verification
./scripts/verify-windows-boundaries.shbun test src/features/editor/lsp/built-in-language-support.test.tsbun test src/features/editor/lsp/language-server-navigation.test.tsbun test src/features/spring/utils/spring-navigation.test.tsbun test src/features/editor/utils/go-to-definition-gesture.test.tsbun test src/features/keymaps/defaults/default-keymaps.git-log.test.tsbun run typecheckinwindows/tauricargo test --manifest-path windows/tauri/src-tauri/Cargo.toml lsp::Not verified on a Windows machine with a live
jdtlssession. Java users are expected to already have a JDK;jdtlsstill needs to be on PATH or in a known install location.