Skip to content

ci: allow unsigned Windows official installers #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1lck merged 2 commits into from
Aug 17, 2026
Merged

ci: allow unsigned Windows official installers #123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9df1d83
ci: allow unsigned Windows official installers
1lck Aug 17, 2026
ce9401e
Merge branch 'preview/0.3.0' into feat/windows-unsigned-release
1lck Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/release-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,16 @@ jobs:
run: ./scripts/build-windows.ps1 -Configuration Release

- name: Import Authenticode certificate
id: signing
shell: pwsh
env:
WINDOWS_SIGNING_CERTIFICATE_BASE64: ${{ secrets.WINDOWS_SIGNING_CERTIFICATE_BASE64 }}
WINDOWS_SIGNING_CERTIFICATE_PASSWORD: ${{ secrets.WINDOWS_SIGNING_CERTIFICATE_PASSWORD }}
run: |
if ([string]::IsNullOrWhiteSpace($env:WINDOWS_SIGNING_CERTIFICATE_BASE64)) {
throw "WINDOWS_SIGNING_CERTIFICATE_BASE64 is required for a signed Windows release."
Write-Output "No Authenticode certificate is configured; the Windows installer will be unsigned."
"signed=false" >> $env:GITHUB_OUTPUT
exit 0
}
$path = Join-Path $env:RUNNER_TEMP "lithe-signing.pfx"
[System.IO.File]::WriteAllBytes(
Expand All @@ -76,13 +79,25 @@ jobs:
-CertStoreLocation Cert:\CurrentUser\My -Password $password
if ($null -eq $certificate) { throw "Could not import the Authenticode certificate." }
"LITHE_WINDOWS_CERTIFICATE_THUMBPRINT=$($certificate.Thumbprint)" >> $env:GITHUB_ENV
"signed=true" >> $env:GITHUB_OUTPUT

- name: Package Windows installer
shell: pwsh
env:
LITHE_VERSION: ${{ steps.version.outputs.version }}
LITHE_WINDOWS_TIMESTAMP_SERVER: ${{ secrets.WINDOWS_TIMESTAMP_SERVER }}
run: ./scripts/package-windows.ps1 -Configuration Release -Version $env:LITHE_VERSION -RequireAuthenticodeSignature
WINDOWS_RELEASE_SIGNED: ${{ steps.signing.outputs.signed }}
run: |
$packageArgs = @(
"-Configuration", "Release",
"-Version", $env:LITHE_VERSION
)
if ($env:WINDOWS_RELEASE_SIGNED -eq "true") {
$packageArgs += "-RequireAuthenticodeSignature"
} else {
Write-Output "Packaging an unsigned Windows installer."
}
./scripts/package-windows.ps1 @packageArgs

- name: Verify installer checksum
shell: pwsh
Expand Down
Loading