Skip to content

feat(windows): add project tab close controls - #139

Merged
1lck merged 2 commits into
1lck:preview/0.3.0from
Mucheen:feat/windows-project-tab-close-controls
Aug 17, 2026
Merged

feat(windows): add project tab close controls#139
1lck merged 2 commits into
1lck:preview/0.3.0from
Mucheen:feat/windows-project-tab-close-controls

Conversation

@Mucheen

@Mucheen Mucheen commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a close control to every Windows project tab
  • keep the active tab close control visible and reveal inactive controls on hover or keyboard focus
  • reuse the existing project close lifecycle with a pending-action guard
  • add localized accessible labels and focused regression coverage

Validation

  • bun test src/features/window/components/project-tab-bar.test.ts src/i18n/locale.test.ts
  • bun run typecheck
  • bunx vp lint src/features/window/components/project-tab-bar.tsx src/features/window/components/project-tab-bar.test.ts src/i18n/locale.ts src/i18n/locale.test.ts
  • bun run build
  • powershell -NoProfile -ExecutionPolicy Bypass -File scripts/verify-windows-boundaries.ps1
  • focused Git tests pass independently; the full Bun run retains the unchanged Preview baseline icon-inventory mismatch and cross-file mock isolation failures

@Mucheen
Mucheen requested a review from 1lck as a code owner August 17, 2026 12:05
@1lck

1lck commented Aug 17, 2026

Copy link
Copy Markdown
Owner

这个要合吗?

@Mucheen

Mucheen commented Aug 17, 2026 via email

Copy link
Copy Markdown
Collaborator Author

@1lck
1lck merged commit 9986153 into 1lck:preview/0.3.0 Aug 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants