fix(windows): complete Simplified Chinese UI - #166
Merged
1lck merged 5 commits intoAug 19, 2026
Conversation
Owner
|
我看你打的是Draft 还没做完是吗 |
Contributor
Author
|
差不多整完了,只是pr没有把截图放上去 |
zqzlq
marked this pull request as ready for review
August 18, 2026 14:30
Contributor
Author
|
算是整完了 |
Collaborator
|
首先这个方案的改动有很多优秀的地方比如对某些语义 key 的前缀添加确实让代码可读性大大提高,这个建议进行保留 但是在汉化层面,为什么不参考一下 MacOS 的额外 i18 映射文件的方式呢——英文就是 source of truth,中文只是一个映射资源,使用Resources/zh-Hans.lproj/Localizable.strings 集中维护映射 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Linked Issue
Fixes #146
Screenshot
Validation
bun run typecheckbun test src/i18n/locale.test.tsgit diff --checkbun run desktop:dev