fix(lsp): launch bundled JDTLS with Java directly - #276
Merged
Conversation
Move packaged JDTLS JVM argument construction into Rust Core and pass platform-resolved launcher, configuration, and Lombok resources through the shared contract. Preserve wrapper fallback for external installations. Refs #273
Reject cross-architecture macOS configuration fallback, validate packaged resources against the target architecture, and cover the ARM packaging path with a regression test. Refs #273
Owner
Author
|
@lithe review |
Contributor
Lithe Review结论: ❓ 审查未完成 审查状态: |
Bundle architecture-specific JDKs in universal apps, select the runtime for the active process architecture, and exercise the default universal package path in CI.\n\nRefs #273
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LanguageServers/jdklayout for single-architecture packages and external wrapper fallback for external JDTLS installationsVerification
./scripts/verify-rust-core.sh./scripts/test-macos.sh(637 tests)./scripts/verify-macos-package.sh(default universal App and DMG; arm64/x86_64 main binary and JDK resources)node scripts/test-verify-download-cache.mjsgit diff --check./scripts/verify-shared-contracts.sh./scripts/verify-service-boundaries.sh./scripts/verify-windows-boundaries.shServiceReadywith bundledjava.exeas the direct child and no shell childCloses #273