feat(app): add theme tokens, translations and toasts - #190
Merged
Merged
Conversation
A fresh checkout has no build_runner asset graph, so committed slang outputs are treated as conflicts and the build aborts; git still decides whether anything changed.
slang_build_runner treats committed outputs as conflicts in a fresh checkout even with --delete-conflicting-outputs; the slang CLI reads slang.yaml and rewrites them in place.
Owner
Author
|
CI 修正:前兩輪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M1 PR 12a:UI 的基礎(ADR 0024 §決定 1–3、7;ADR 0023 §決定 1–3、5;擁有者決定 2)。PR 12 拆成 12a 與 12b,由擁有者核准。
做了什麼
lib/ui/theme/):AppTokens包含間距、圓角、成功與警告兩組語意色、焦點框;元件的固定尺寸放AppLayout;WindowClass:與 M3 同值,依內容區寬度判斷。zh-TW為 base、zh-CN、en),產生檔比照 drift 提交,CI 現有的 codegen 檢查一併涵蓋。MaterialApp.locale用帶書寫系統的形式,例如zh-Hant-TW。zh-Hant,漢字才會用繁中字形。ErrorMessageKey對到翻譯字串。AppError.messageArgs收窄成Map<ErrorMessageArg, int>,插件或伺服器的文字在型別上就放不進畫面。Toaster與ToastHost放在MaterialApp.builder,在全螢幕頁、對話框、底部面板之上都看得到。clear。驗證
dart analyze --fatal-infos、flutter analyze都零問題;flutter test714 個通過;哨兵通過;Windows 與 Android 的 dev 建置都成功。verify-on-device):UI locale applied的字型清單都對;intl的直接依賴:Review 指南
lib/ui/toast/toast_host.dart:層級、取代、停留。lib/ui/i18n/ui_locale.dart:系統語言的對應,以及字型、文字 locale 的推導。lib/core/errors/app_error.dart:messageArgs的新型別。