feat(app): add the shell, search, settings and player bar - #191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M1 PR 12b:外殼、搜尋、設定、播放列、快捷鍵(ADR 0024 §決定 3、5、6、8;ADR 0023 §決定 2;擁有者決定 2)。完成後通過 M1 的端到端驗收。
做了什麼
NavigationBar,600–1199 用NavigationRail,≥ 1200 用常駐NavigationDrawer。導覽項只有「搜尋」「設定」。外殼會發佈底部被佔用的高度,提示就浮在播放列與導覽列之上。PlaybackController;Toaster.error。--fmp-dev-playback,保留--fmp-dev-plugin;integration_test/toast_layering_test.dart,在實機上驗證提示浮在對話框與全螢幕頁之上;fail時會以限流失敗,給離線驗證錯誤提示用,只打包在 dev;verify-on-deviceskill 與三份 spec 同步更新。驗證
dart analyze --fatal-infos、flutter analyze都零問題;flutter test784 個通過,含 golden 與 guideline;哨兵通過;兩個 dev 建置都成功。toast_layering_test.dart:2/2 通過。-no-audio)|模式:測試插件,不連網toast_layering_test.dart:2/2 通過。wbi/view加一次playurl。window_shot.ps1被存成 LF 行尾,在 Big5 系統上解析錯亂。請擁有者確認
後續(記在 M1
implement.md)Unsupported(M2);