Repository navigation
Conversation
The Linux/Mono 1.1.3 installer PE was flagged by Defender as Trojan:Win32/Wacatac.B!ml. Add a windows-latest workflow that runs the existing Build-OneFileInstaller.ps1 path.
The Mono-built EXE called String.TrimEnd() in a way .NET Framework 4.x does not have, and Defender also flagged that PE. Replace dist with the windows-latest csc artifact and bind log TrimEnd to the Framework overload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.1.3 installer attached to the release was compiled with Mono on Linux. Windows Defender flagged that PE as
Trojan:Win32/Wacatac.B!mland removed it.This adds a
windows-latestworkflow that runs the existingBuild-OneFileInstaller.ps1path (csc.exefrom .NET Framework 4.x). The flagged EXE has already been pulled from the v1.1.3 release; testers can drop insmvr_native_vr_v1.addon64until the Windows-built installer is reattached.