Skip to content

Rewrite Library - #6

Open
sr229 wants to merge 13 commits into
26medias:masterfrom
ClarityMoe:es6-rewrite
Open

Rewrite Library#6
sr229 wants to merge 13 commits into
26medias:masterfrom
ClarityMoe:es6-rewrite

Conversation

@sr229

@sr229 sr229 commented Apr 9, 2017

Copy link
Copy Markdown

Do not merge yet! This is a Proof-of-Concept PR atm until we can get the test file working

What we changed

  • Rewrite to ECMAScript 6
  • Removed dependency to things ECMAScript 6 already supports.

What doesn't work

the test file. We don't know why.

@26medias

26medias commented Apr 9, 2017

Copy link
Copy Markdown
Owner

Neat.

Have you been able to train and generate text yet?

@Ovyerus

Ovyerus commented Apr 11, 2017

Copy link
Copy Markdown

Test file doesn't work, but neither does the original test, at least from what I've tried.

@26medias

Copy link
Copy Markdown
Owner

Oh.

I'll try to make some time to re-install and check it out.

@26medias 26medias left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@sr229

sr229 commented Jul 29, 2017

Copy link
Copy Markdown
Author

brill-pos-tagger seems to have a broken logger.

@matt-cook

Copy link
Copy Markdown

related: Hugo-ter-Doest/brill-pos-tagger#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants