Skip to content

Issue-#352 No longer change mod settings in game #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
26tscole merged 1 commit into from
May 5, 2026
Merged

Issue-#352 No longer change mod settings in game #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 70 additions & 11 deletions ui/smods_menu/customization_tab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,36 @@
local function mp_is_in_active_match()
return MP.LOBBY
and MP.LOBBY.code
and G.STAGE
and G.STAGES
and G.STAGE ~= G.STAGES.MAIN_MENU
end

local function mp_settings_locked_message()
MP.UI.UTILS.overlay_message("Multiplayer profile settings cannot be changed during a match.")
end

local function guarded_save_preview()
if mp_is_in_active_match() then
mp_settings_locked_message()
MP.PREVIEW.text = SMODS.Mods["Multiplayer"].config.preview.text or ""
MP.PREVIEW.button = SMODS.Mods["Multiplayer"].config.preview.button or ""
return
end

MP.UTILS.save_preview(MP.PREVIEW)
end

local function guarded_save_username()
if mp_is_in_active_match() then
mp_settings_locked_message()
MP.LOBBY.username = MP.UTILS.get_username()
return
end

MP.UTILS.save_username(MP.LOBBY.username)
end

function MP.UI.create_customization_tab()
local blind_anim = AnimatedSprite(
0,
Expand All @@ -11,8 +44,12 @@ function MP.UI.create_customization_tab()
{ shader = "dissolve", shadow_height = 0.05 },
{ shader = "dissolve" },
})

MP.PREVIEW.text = SMODS.Mods["Multiplayer"].config.preview.text or ""
MP.PREVIEW.button = SMODS.Mods["Multiplayer"].config.preview.button or ""

local settings_locked = mp_is_in_active_match()

local ret = {
n = G.UIT.ROOT,
config = {
Expand All @@ -23,7 +60,25 @@ function MP.UI.create_customization_tab()
colour = G.C.BLACK,
},
nodes = {
MP.INTEGRATIONS.Preview and {
settings_locked and {
n = G.UIT.R,
config = {
padding = 0.2,
align = "cm",
},
nodes = {
{
n = G.UIT.T,
config = {
scale = 0.45,
text = "Profile settings are locked during a match",
colour = G.C.RED,
},
},
},
} or nil,

MP.INTEGRATIONS.Preview and not settings_locked and {
n = G.UIT.R,
config = {
padding = 0.10,
Expand All @@ -41,7 +96,8 @@ function MP.UI.create_customization_tab()
},
},
} or nil,
MP.INTEGRATIONS.Preview and {

MP.INTEGRATIONS.Preview and not settings_locked and {
n = G.UIT.R,
config = {
padding = 0,
Expand All @@ -59,7 +115,8 @@ function MP.UI.create_customization_tab()
},
},
} or nil,
MP.INTEGRATIONS.Preview

MP.INTEGRATIONS.Preview and not settings_locked
and {
n = G.UIT.R,
config = {
Expand All @@ -80,7 +137,7 @@ function MP.UI.create_customization_tab()
extended_corpus = true,
keyboard_offset = -3,
callback = function(val)
MP.UTILS.save_preview(MP.PREVIEW)
guarded_save_preview()
end,
}),
create_text_input({
Expand All @@ -95,13 +152,14 @@ function MP.UI.create_customization_tab()
extended_corpus = true,
keyboard_offset = -3,
callback = function(val)
MP.UTILS.save_preview(MP.PREVIEW)
guarded_save_preview()
end,
}),
},
}
or nil,
{

not settings_locked and {
n = G.UIT.R,
config = {
padding = 0.5,
Expand All @@ -127,7 +185,7 @@ function MP.UI.create_customization_tab()
extended_corpus = true,
keyboard_offset = -3,
callback = function(val)
MP.UTILS.save_username(MP.LOBBY.username)
guarded_save_username()
end,
}),
{
Expand All @@ -139,8 +197,9 @@ function MP.UI.create_customization_tab()
},
},
},
},
{
} or nil,

not settings_locked and {
n = G.UIT.R,
config = {
padding = 0.1,
Expand Down Expand Up @@ -200,7 +259,7 @@ function MP.UI.create_customization_tab()
},
},
},
},
} or nil,
},
}
return ret
Expand All @@ -213,4 +272,4 @@ function MP.UI.create_extra_tabs()
tab_definition_function = MP.UI.create_customization_tab,
},
}
end
end
22 changes: 20 additions & 2 deletions ui/smods_menu/smods_menu.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ function G.FUNCS.bmp_github(e)
end

function G.FUNCS.change_blind_col(args) -- all we're doing is just saving + redefining the ui elements here
if MP.LOBBY
and MP.LOBBY.code
and G.STAGE
and G.STAGES
and G.STAGE ~= G.STAGES.MAIN_MENU then
MP.UI.UTILS.overlay_message("Multiplayer profile settings cannot be changed during a match.")
return
end

MP.UTILS.save_blind_col(args.to_val)
MP.LOBBY.blind_col = args.to_val
local sprite = G.OVERLAY_MENU:get_UIE_by_ID("blind_col_changer_sprite")
Expand All @@ -37,6 +46,15 @@ function G.FUNCS.change_blind_col(args) -- all we're doing is just saving + rede
end

function G.FUNCS.mp_change_timersfx(args)
if MP.LOBBY
and MP.LOBBY.code
and G.STAGE
and G.STAGES
and G.STAGE ~= G.STAGES.MAIN_MENU then
MP.UI.UTILS.overlay_message("Multiplayer settings cannot be changed during a match.")
return
end

SMODS.Mods["Multiplayer"].config.timersfx = args.to_key
SMODS.save_mod_config(SMODS.Mods["Multiplayer"]) -- probably unnecessary?
end
SMODS.save_mod_config(SMODS.Mods["Multiplayer"])
end
Loading