fix: recommended setup's lazy-loading breaks default keymaps - #23
Merged
Conversation
Owner
|
@NickvanDyke thanks for raising the PR, I will make a few minor tweaks after merge :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this plugin, it has saved me many a trip to the nerdy font website!
What does the PR do? (Required)
cmd = 'Nerdy'in the recommended lazy.nvim setup means the plugin is not loaded until that command. Thus the internal default keymaps are not created and the user must manually run:Nerdyto load and use the plugin.I chose to solve this by moving the internal keymaps to lazy.nvim's
keysarray, so the plugin loads on these keymaps. This fixes the lazy-loading issue and adheres to best practices 馃檪But you could also just remove the
cmdkey from the recommended lazy.nvim config.Checklist (Required)
Evidence (Required)
Without this PR: Enters insert mode because the keys aren't mapped.
Screen.Recording.2026-01-16.at.8.07.23.AM.mov
With this PR: Opens select as expected.
Screen.Recording.2026-01-16.at.8.06.33.AM.mov