Skip to content

fix collection exec for get type #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serp-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix collection exec for get type #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/collection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@

var params = {
type: execMethodType,
dataType: 'json',
contentType: 'application/json',
processData: false
dataType: 'json'
};

// Ensure that we have a URL and add method name to it
Expand All @@ -60,7 +58,15 @@
}

// stringify data to json
if (options.data && _.isObject(options.data)) {
if (
options.data &&
_.isObject(options.data) &&
_([
'post', 'patch', 'put'
]).contains((options.type || params.type).toLowerCase())

@artzhookov artzhookov Mar 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good practice to split such huge constructions to smaller pieces to prevent unreadable if conditions.
In this case I'd define a type variable var type = (options.type || params.type).toLowerCase(); above and change this line to

_(['post', 'patch', 'put']).contains(type)

) {
params.processData = false;
params.contentType = 'application/json';
options.data = JSON.stringify(options.data);
}

Expand Down