x11: log aw-none if _NET_ACTIVE_WINDOW == 0 - #30
Conversation
|
Thank you, the fix makes sense, but it needs to come first. If you prefer, I can cherry-pick it a bit later without the other change, unless you do. |
IIRC they are intertwined, so probably there will be some conflicts when removing the first commit. I'd do it once I find the time and #28 is merged. Feel free to do this earlier, if you'd like |
|
@2e3s I think it should be good now |
|
@powellnorma Yes, thank you, however, I realized that I don't understand the utility of the change. As far as I understand, now nothing is sent is no window is active. What is the use case where this is a problem and a window/app This is also the behavior on other OS, like MacOS. So sending nothing seems at least consistent. |
|
Could it be that maybe before the case was not handled, and it just crashed? I am not 100% sure myself anymore. |
In that case, probably the PR could be adjusted such that it returns nothing instead of "aw-none". But it's still worth adding this logic, as to prevent crashes. Does that make sense? |
I doubt, honestly, because it's a normal use case to close/hide all windows. Someone would notice, I assume. I would notice, I used X11 just recently.
I thought this should be the current behaviour, so that the window watcher doesn't send anything to the server (so the timeline there shows an empty space). I tried it now under KDE & Wayland and, unlike MacOS, this combination shows "plasmashell" for no opened windows 🤷 |
|
Hm, but if you look at the code, previously active_window_data always returned
Yes maybe different window manager handle "no focussed window" differently. How does e.g. i3wm handle it? |
2 participants
Based on #28