Repository navigation
Add a test harness, CI and current package metadata - #1
Merged
Merged
Conversation
Add node:test tests against a small in-process Electrum server over TCP and TLS (with a committed, test-only certificate), covering requests, errors, concurrency, batches, notifications and close. Run them in CI on Node 18, 20 and 22. Point the repository, bugs and homepage fields at this fork, require Node 18 or later, and publish only index.js and lib.
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were no tests (
npm testprinted an error). This adds the harness the following fixes need.node:testtests against a small in-process Electrum server over TCP and TLS: version negotiation, results, server errors, concurrent requests, batches, notifications, and close. The TLS fixture (test/fixtures) is a test-only self-signed certificate forlocalhost/127.0.0.1; its key protects nothing.package.json: repository, bugs and homepage point at this fork;enginesrequires Node 18 or later (it said 6); onlyindex.jsandlibare published;npm testruns the tests.No behaviour change. Checked locally: 14 tests pass on Node 22.