Repository navigation
v1.0.1: fixes from the external audit - #1
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the external audit of v1.0.0. Every finding was reproduced on
04272a0before it was fixed, and each has a regression test.?f=allowedrobots_snapshot.py; empty rule set raisesModuleNotFoundError: playwrightavito_clilauncher: says to installavito-scraper[playwright], exit 2returnbeforefinish_runlatest_attempt.meta.jsonwithexit_code,error_classexceptBridgeErroris 5; unexpected exceptions exit 1 with masked tracebackdiff_runswithout metadata--force; also refuses different schema versionsschema_version= Product names onlyCI now runs
ci_checks.py --wheel-check: build, install outside the checkout, check robots verdicts and the console command with and without the playwright extra.Not changed, and why
::warning::, and the README says what the badge does and does not prove.src/layout, dropping pyppeteer: larger decisions for a minor release.Verified locally: offline suite 472 checks / 0 failed (and green in the selenium and pyppeteer venvs), pytest 64 passed,
ci_checks --alland--wheel-checkpass, a live Playwright run over the Scraping Browser returned 50 rows, exit 0.🤖 Generated with Claude Code