Skip to content

v1.0.1: fixes from the external audit - #1

Merged
2ione merged 1 commit into
mainfrom
fix/audit-1.0.1
Oct 7, 2026
Merged

2ione merged 1 commit into
mainfrom
fix/audit-1.0.1

Conversation

@2ione

@2ione 2ione commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Fixes from the external audit of v1.0.0. Every finding was reproduced on 04272a0 before it was fixed, and each has a regression test.

Finding Reproduced Fix
P0-1 wheel ships no robots rules installed wheel: 0 rules, ?f= allowed snapshot is now the module robots_snapshot.py; empty rule set raises
P0-2 console command needs playwright ModuleNotFoundError: playwright avito_cli launcher: says to install avito-scraper[playwright], exit 2
P1-2 no attempt metadata on failed start / crash return before finish_run every ending writes latest_attempt.meta.json with exit_code, error_class
P1-3 any exception = exit 5 broad except only BridgeError is 5; unexpected exceptions exit 1 with masked traceback
P1-4 diff_runs without metadata sidecar-less files compared refused unless --force; also refuses different schema versions
P2-1 schema_version = Product names only per mode's row class, names + order + types
P2-2 template leftovers bershka/homedepot in requirements, .gitignore, .dockerignore; review prompt about EUR/Player/Transfer rewritten; vocabulary check now covers every tracked file

CI now runs ci_checks.py --wheel-check: build, install outside the checkout, check robots verdicts and the console command with and without the playwright extra.

Not changed, and why

  • Canary still goes green on SKIP (family rule: an always-red check gets ignored). The skip now raises a ::warning::, and the README says what the badge does and does not prove.
  • Actions SHA pinning, lock files, src/ layout, dropping pyppeteer: larger decisions for a minor release.

Verified locally: offline suite 472 checks / 0 failed (and green in the selenium and pyppeteer venvs), pytest 64 passed, ci_checks --all and --wheel-check pass, a live Playwright run over the Scraping Browser returned 50 rows, exit 0.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@2ione
2ione merged commit 352b699 into main Oct 7, 2026
7 checks passed
@2ione 2ione mentioned this pull request Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant