Repository navigation
AWS WAF cookie domain from the site's own list; engine-smoke checks the import - #2
Merged
Merged
Conversation
…he import - page_flow.cookie_domain reads window.awsWafCookieDomainList from the challenge page: binance lists binance.com (-> .binance.com, as measured), transfermarkt lists nothing (-> the page host). 'The registrable domain' was binance's list, not a rule. Live: solved, token on .binance.com, page served (pyppeteer, 29 s). - tests.yml engine-smoke imports the installed engine instead of grepping the suite's wording, as 25 sibling repos now do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aws-waf-tokencookie domain is now read from the challenge page's ownwindow.awsWafCookieDomainList. Binance's list is['binance.com', …], which gives.binance.com, the domain measured to work. transfermarkt's is[], which gives the page host. So "the registrable domain" was a property of Binance, not a rule. Live on 2026-09-24: solved in 29 s through pyppeteer, token on.binance.com, page served.engine-smokenow imports the installed engine (python -c 'import <engine>_scraper') instead of grepping the suite's wording, the same fix merged in 25 sibling repos today.Tests: 353 offline checks pass, including cookie-domain cases for a listed domain, an empty list and an unlisted host.
🤖 Generated with Claude Code