Repository navigation
Fix the red daily canary (real 0.0% funded campaign); warn on --key in argv - #6
Merged
Merged
Conversation
…n argv The daily canary was red 2026-10-07..2026-10-12 although the run was healthy (72 rows, complete, 3/3 pages). Its sanity check rejected pct_funded <= 0 and a real campaign (10,000 raised against a goal of 900,000,000) rounds to 0.0. The check now fails on a negative percentage or one without a positive goal. Parser unchanged; a smoke check pins the case (controlled: red when 0.0 becomes None). scraper_api_client.py warns when the key arrives via argv. README says how to read capped_by_site. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jehrr
marked this pull request as ready for review
October 13, 2026 10:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Canary was red 2026-10-07..2026-10-12 with a healthy run (72 rows, complete, 3/3). Its check rejected
pct_funded <= 0; sku 443208 (10,000 raised vs goal 900,000,000) rounds to 0.0 — a real figure. Parser was right.Changes
Not changed (from the audit)
Lock files (would stop the canary testing new releases; Docker-only constraints is a possible follow-up), scope_complete field (duplicates capped_by_site), dropping engines, skip-age metric (cannot tell skipped from real success without a marker), provider comparison. CI for this PR not yet watched; merge left to the owner.
🤖 Generated with Claude Code