Repository navigation
Family sync 2026-09-29: fingerprint script, pyppeteer proxy auth, CI pipefail, skips, gitignore - #6
Merged
Merged
Conversation
…pipefail, skips, gitignore Found by a family-wide pass against the template on 2026-09-29; each one made a documented feature do less than it said while the run reported success. Details and evidence in CHANGELOG.md [Unreleased]. - --fingerprint's init script was broken JavaScript and never ran; now node --check'ed by the suite. - pyppeteer's page.authenticate() uses a CDP method current Chrome removed; proxy 407s are answered through the Fetch domain. - The engine CI step piped the suite into tee without pipefail, so a failing suite was green; now `shell: bash`, an import check, and a suite guard on every piped step. - Skipped checks were counted as passed; now counted separately. - env_config.py --help no longer reads .env. - .gitignore covers .env*, run directories and paged dumps by shape. - One Scraping Browser connect policy (template §26): retry a lock or an outage 3x3 s, never a 401, name the cause (incl. profile_locked). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
With pipefail on, the engine CI jobs showed they had been red: the scan walked into CI's own .venv-<engine> and flagged pip's and selenium's vendored code (32-hex in packaging/_elffile.py, URLs in urllib3 and websocket tests, a token in selenium's devtools). A directory holding pyvenv.cfg is a virtualenv whatever it is called (template §23); ordinary untracked files are still read. Both planted in a suite check. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The fingerprint-refusal check launches playwright_scraper for real, and it starts Chromium before it fetches; the job had no browser, so it exited 1 instead of 5. Red since it was added, hidden until pipefail. Playwright installs its Chromium; pyppeteer/Selenium use the runner's Google Chrome (as in rosreestr-scraper, where all three are green). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Family-wide pass against the template (CLAUDE-FIX2) on 2026-09-29. Every item below made a documented feature do less than it said while the run reported success; each has a suite check, and each check was confirmed to go RED with the old defect planted.
Fixed
--fingerprintnever patched anything: the init script was syntactically broken JavaScript (( => {). Nownode --checked by the suite.page.authenticate()uses the removedNetwork.setRequestInterception(measured 2026-09-29 in rosreestr-scraper). Now answered through the CDP Fetch domain; verified against a local Basic-auth proxy.teewithout pipefail, so a failing suite was green. Nowshell: bash, an import check first, and a suite guard on every piped step.env_config.py --helpread.env..gitignorelet.env.bak,live/and paged dumps through.Changed
profile_locked, met live in rosreestr-scraper's canary on 2026-09-29.Details and evidence: CHANGELOG.md [Unreleased]. Not in this PR: a version bump (its own commit, per the release process).
🤖 Generated with Claude Code