Repository navigation
Audit follow-ups: honest engines badge, dated live checks, canary env report - #2
Merged
Merged
Conversation
…ironment report Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jehrr
force-pushed
the
audit-2026-10-05-followups
branch
from
October 15, 2026 21:57
e7d9cc8 to
46174b1
Compare
jehrr
marked this pull request as ready for review
October 15, 2026 22:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from a third-party audit of v0.1.1 (2026-10-05). Each audit claim was checked against this commit first; most were already addressed, so this PR is deliberately small.
Changed
enginesbadge: no longer lists three engines as equals (pyppeteer measured over CDP, Selenium local only), matching the engine table..github/env_report.py, called by both canary jobs: prints Python, TLS library, driver, Chromium versions and the endpoint KIND, never the endpoint. A red canary then says from its own log whether the site or the runner moved.Checked
smoke_test.py: 360 passed, 0 failed (engine groups skipped: no driver installed locally).ci_checks.py --secret-check: 45 files, nothing credential-shaped.env_report.pyruns with the driver absent.--chromiumpath.Not changed, and why
last_hotel_id+window+shown, tied to the session. Whether it replays in a new session is unmeasured and needs a live Scraping Browser; until then a resume could splice two orderings silently. Needs the experiment first.canary_assert.pyalready checks rows, uniqueness, price share, currency, original_price and zero ratings; thedatacentrejob already runs daily.🤖 Generated with Claude Code