Repository navigation
Name the real cause of a refused --cdp-endpoint; judge claps per source in the tag canary - #10
Merged
Merged
Conversation
…ce in the tag canary A refused CDP connection always explained profile_locked, so an expired login (HTTP 401) sent the reader looking for a run holding the pid. The text now follows what the failure says. pyppeteer also exited 1 with a traceback on the same failure; it now exits 5 like Playwright, with the password masked. The tag-feed canary asserted that one row had claps. Claps and responses ride on Apollo rows only (34-35 per run, 100% in 3 of 4 live runs, 30 of 35 in the fourth; 0 of 20 JSON-LD rows in every run), so it now judges the Apollo rows with floors that admit the measured worst day. Both verified by planting faults and requiring the named check to go red. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from the 2026-10-05 audit, after checking each against current main (the audit was cut from 12bd047, eight commits back).
Changed
1. CDP connect errors say why. Every failure was followed by the
profile_lockedparagraph, so a 401 (deny_no_user, expired login) was explained as a held pid.page_flow.cdp_connect_advicenow picks the text from the failure itself: expired credentials, held profile, unreachable host, or for a bare timeout an honest "no status, try fresh credentials first". pyppeteer never surfaces the status of a rejected upgrade, so it gets the ambiguous text. pyppeteer also died with a traceback and exit 1 on this failure; it now exits 5 like Playwright, password masked.2. Tag canary judges claps per source. The old check was "at least one row has claps". Measured 2026-10-05, four live runs of /tag/python: Apollo rows 34-35 per run with claps and responses on 100% in three runs and 30 of 35 in the fourth; the 20 JSON-LD rows carry neither in any run. The canary now requires at least 15 Apollo rows, claps and responses on at least 80% of them (admits the 30 of 35 day), and fails if a JSON-LD row ever carries either.
Verification
Not changed
requires-python(decided separately, family-wide).🤖 Generated with Claude Code