Repository navigation
Remove donor-site leftovers from prose, help text and templates - #7
Merged
Merged
Conversation
- engines: --mode/--category/--pages/--concurrency help described another
site's questions/topics/vote counts, and claimed no mode has per-page
addresses although --mode archive does; readiness log named another
site's card kind in all three engines ("No story cards" now)
- scraper_api_client.py: refusal messages and --url help claimed the API's
exit gets nothing and a rendered browser is required; README measured it
served on all four modes
- diff_runs.py: docstring, comments, --price-tolerance-pct help and the
source_changed line rewritten for stories/tag feeds; dropped text_chars
(not a column here) from the view fields
- output_writer.py: mode default "topic" -> "tag"
- CONTRIBUTING.md, bug_report.yml, site_changed.yml rewritten from this
repo's README and parser
- requirements*.txt: another repo's name and browser measurements replaced
with this repo's own
- .dockerignore: donor output prefix -> medium_posts.*
- TROUBLESHOOTING.md and suite comments; min_matches check used a
non-existent mode
- smoke_test.py: foreign-vocabulary guard now scans .txt and .dockerignore
and knows the Q&A sibling's vocabulary (controlled red on both)
- CHANGELOG: Unreleased entry
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- SECURITY.md said the project has no releases or version tags; it has both (gh release list). Supported versions now names the latest release and main, in the wording bbb-scraper and foodpanda-scraper already use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jehrr
force-pushed
the
fix/donor-leftovers
branch
from
September 28, 2026 19:50
2f15358 to
533619c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo was bootstrapped from a Q&A-site sibling and a rental-site sibling. Their names had been scrubbed; their vocabulary and measurements had not.
Fixed
--mode,--category,--pages,--concurrency) and inscraper_api_client.py --urldescribed questions, topics and vote counts.--pages/--concurrencyalso said no mode has per-page addresses, which contradicts--mode archiveand the Playwright worker pool.--retries/--cdp-url.diff_runs.py: docstring, comments,--price-tolerance-pcthelp and thesource_changedoutput line rewritten for stories and tag/archive/author/post views.text_charsremoved from the view fields because it is not a column here. Dropped an unmeasured "1,733 views" claim.output_writer.py:modedefault was"topic", which is not a mode here. It is now"tag". Every engine passes its mode explicitly.bug_report.yml,site_changed.ymldescribed another site's inline payload, card hooks, columns and URLs. They are rewritten from this repo's README andproduct_parser.pydocstring, and every number in them comes from those files.requirements*.txt: another repo's name, and its browser measurements, includingplaywright install chrome. They now carry this repo's own findings (bundled Chromium is fine; pyppeteer's bundled Chrome/117 was refused 3/3)..dockerignore: donor output prefix replaced withmedium_posts.*/medium_posts_*.*, taken from the engines'--outdefault.TROUBLESHOOTING.mdand suite comments. Amin_matchescheck exercised a mode calledquestion; it now usestag, plus a new post-mode assertion..txtand.dockerignore, and it knows the Q&A sibling's vocabulary. Controlled: planting the oldrequirements.txtheader, and separately the old Selenium log line, each turned the suite red on that check.Kept, deliberately
smoke_test.py, which exists on purpose.foodpanda-scraperin the README and in a suite comment, the craigslist note in.gitignore, and the "a sibling repo …" comments inpage_flow.pyand the engines.fixtures_generated.json, which is real page data.Not changed, noted
TROUBLESHOOTING.mdsays there is "nothing to hand 2Captcha" for the managed challenge, while the README and CHANGELOG 0.1.1 say the Turnstile parameters can be intercepted and solved. That is not a donor leftover, so it is out of scope for this PR.Suite: green before and after (709 → 715 PASS). The three engine groups skip locally because no engine is installed.
ci_checks.py --secret-check --help-check --sample-checkall pass.🤖 Generated with Claude Code