Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions .github/workflows/canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,8 @@ name: canary
# so the same two lines are correct with and without them.
on:
schedule:
# Once a day, off the hour, so it is not competing with everyone else's
# Once a week (Mondays), off the hour, so it is not competing with everyone else's
# on-the-hour cron jobs for runner availability.
- cron: "37 7 * * *"
# Mondays: the same jobs, WITH the paid secrets (proxy, Scraping Browser,
# captcha key). On the daily run above those secrets read as empty, so
# it takes the free no-secret route and bills nothing.
- cron: "37 7 * * 1"
workflow_dispatch:

Expand All @@ -55,8 +51,8 @@ jobs:
# `secrets` is not available in a job-level `if`, so presence is tested
# here, once, and read from each step's `if` and shell below. These are
# the strings "true"/"false", never the secret itself.
HAVE_CDP: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.TRANSFERMARKT_CDP_ENDPOINT != '' }}
HAVE_PROXY: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.TRANSFERMARKT_PROXY != '' }}
HAVE_CDP: ${{ secrets.TRANSFERMARKT_CDP_ENDPOINT != '' }}
HAVE_PROXY: ${{ secrets.TRANSFERMARKT_PROXY != '' }}
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -97,8 +93,8 @@ jobs:
# Through the environment, never argv (see the header). Unset
# secrets arrive as "" and env_config.py treats that as unset, so
# these lines are correct in both configurations.
TRANSFERMARKT_CDP_ENDPOINT: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.TRANSFERMARKT_CDP_ENDPOINT || '' }}
TRANSFERMARKT_PROXY: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.TRANSFERMARKT_PROXY || '' }}
TRANSFERMARKT_CDP_ENDPOINT: ${{ secrets.TRANSFERMARKT_CDP_ENDPOINT }}
TRANSFERMARKT_PROXY: ${{ secrets.TRANSFERMARKT_PROXY }}
run: |
set +e
python3 playwright_scraper.py \
Expand All @@ -116,8 +112,8 @@ jobs:
# 4 pages (77 transfers) the same day.
continue-on-error: true
env:
TRANSFERMARKT_CDP_ENDPOINT: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.TRANSFERMARKT_CDP_ENDPOINT || '' }}
TRANSFERMARKT_PROXY: ${{ (github.event_name != 'schedule' || github.event.schedule == '37 7 * * 1') && secrets.TRANSFERMARKT_PROXY || '' }}
TRANSFERMARKT_CDP_ENDPOINT: ${{ secrets.TRANSFERMARKT_CDP_ENDPOINT }}
TRANSFERMARKT_PROXY: ${{ secrets.TRANSFERMARKT_PROXY }}
run: |
set +e
python3 playwright_scraper.py \
Expand Down
4 changes: 1 addition & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

### Changed

- CI only: the canary's optional paid secrets `TRANSFERMARKT_CDP_ENDPOINT`, `TRANSFERMARKT_PROXY` now reach it only on a new weekly
run (Mondays 07:37 UTC) and on a manual dispatch. The daily run keeps its
schedule and takes the free route without them, so it bills nothing.
- CI only: the canary now runs weekly (Mondays 07:37 UTC) and on a manual dispatch, with its optional secrets `TRANSFERMARKT_CDP_ENDPOINT`, `TRANSFERMARKT_PROXY` passed on every run; the daily schedule is removed.

## [1.2.0] — 2026-10-16

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ If you already have proxies from somewhere else, `--proxy-file` takes any
list.

**None of these was needed from a GitHub runner on the days measured.** The
daily canary runs the Playwright engine from a bare runner with no key, no
weekly canary runs the Playwright engine from a bare runner with no key, no
proxy and no endpoint; from 2026-10-06 to 2026-10-15 every run read 75 rows
over 3 market-values pages, the AWS WAF *challenge* action clearing by
itself in about a second. That is a fact about those runners' addresses on
Expand Down
Loading