Repository navigation
Audit 2026-10-08: a moved shape is never an empty listing (v0.1.1) - #1
Merged
Merged
Conversation
- is_sponsored only on a positive marker (MediaZeroKm / AdvertisementLink; 3/3 tiles have both, 0/3,386 listings have either). A listing record that cannot be read is counted (malformed_records); a page of them is parser_found_nothing: exit 5, or 6 with earlier pages kept. Before: a renamed UniqueId read as an empty page, exit 4 on page 1 and a complete exit-0 run on page 2. - columns_below_floor in the sidecar, not only the log; canary fails on it and on malformed records. - Ad-mode query identity is the set of adverts (ads_sha256), not the count; diff_runs also refuses search runs of different depth. - Skipped canary runs say so in their summary; README says the badge is green because it skips. Each fix pinned by a check a planted fault turns red (6/6, run without bytecode). Live: 94 rows, 0 malformed, no shortfall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works through the third-party audit of v0.1.0 (2026-10-08, commit
cfab156). Every finding was reproduced before anything changed, and every fix is pinned by a check that a planted fault turns red (6 of 6, run without bytecode).Accepted
P1 — a moved shape read as advertising, then as an empty listing. Reproduced, and worse than reported: with
UniqueIdrenamed on page 2, a 3-page run endedcomplete, exit 0; withSellerrenamed on page 1, the search read as empty (exit 4). Now:is_sponsoredonly on a positive marker. Across every capture, 3 of 3 sponsored tiles carryMediaZeroKmandAdvertisementLink, and 0 of 3,386 listings carry either.malformed_records). A page of them isparser_found_nothing: exit 5, or exit 6 with earlier pages kept. This is binance's_unreadrule, tightened by a stronger signal than arithmetic: the records are in the response.columns_below_floorgoes into the sidecar, not only the log. The canary fails on it and on malformed records.P2 — ad-mode identity was a count. The query now carries
ads_sha256(order-independent; gone adverts stay in the asked scope), and the sidecar listsads_requested.diff_runs.pyalso refuses search runs of differentpages_requested.Missing negative tests — added: an id renamed on page 1 and on page 2, one bad record among five, a moved
Seller, two advert lists of one length, two search depths.Accepted in part
"The canary's green badge proves nothing." True here, because this repo has no proxy secret, so every run skips. But skipping is deliberate: a canary that cannot pass must skip rather than be red every day. I did not build "last real success" tracking. Instead, a skipped run now says so at the top of its summary, and the README says the badge is green because it skips.
Not changed
check_ad_mode_end_to_endruns dealer, gone, private and bike adverts in one list and assertscomplete, the gone one inads_gone, and three rows.partial— not adopted.partialmeans pages were left unfetched, and here nothing was. The run stayscompleteand carriesmalformed_records, which the canary fails on. A page with no readable record is notcomplete.diff_runs.pygives you.Live, 2026-10-08
Playwright, Gol, 2 pages through a residential exit: 94 rows,
complete,malformed_records: 0,columns_below_floor: [], BRL,total_results: 1894.🤖 Generated with Claude Code