Fix #634: GaussianNB yellow border activation and missing training parameters - #707
Open
ArsalanAnwer0 wants to merge 2 commits into
Open
Fix #634: GaussianNB yellow border activation and missing training parameters#707ArsalanAnwer0 wants to merge 2 commits into
ArsalanAnwer0 wants to merge 2 commits into
Conversation
Contributor
|
Great work on this PR! You have successfully resolved both the UI inconsistency and the functional gap by adding the missing var_smoothing and priors training parameters for the Gaussian Naive Bayes model. The layout remains clean and matches the structure used for the other AI models. Everything looks correct and fully addresses issue #634. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #634 two UI issues with the Gaussian Naive Bayes model in
ArtificialIntelligence.qml:#439566(greenish) instead ofyellow, making it visually inconsistent with Random Forest and Deep Learning.var_smoothingandpriorsinput fields, consistent with how RF and DL parameters are structured.Changes
ArtificialIntelligence.qmlborder.coloron GaussianNB button:#439566→"yellow"gnbVarSmoothingandgnbPriorsproperty definitions (alongside existing RF/DL properties)ColumnLayoutparameter section — visible only whencurrentModel === "GaussianNB"withvar_smoothingandpriorsTextFieldsScreenshots
Fix 1 Yellow border on GaussianNB activation (consistent with RF and DL)
Random Forest active (for reference):

GaussianNB active yellow border now showing correctly:

Fix 2 Training parameters now visible when GaussianNB is selected in Train mode
GaussianNB in Train mode

var_smoothingandpriorsnow appear:Random Forest in Train mode (for comparison):

Deep Learning in Train mode (for comparison):

Test plan
var_smoothingandpriorsfields appear in the Parameters panel when GaussianNB is selected in Train mode