Fix #617: run anonymize in background thread to prevent GUI freeze - #708
Open
Esma-Ali wants to merge 1 commit into
Open
Fix #617: run anonymize in background thread to prevent GUI freeze#708Esma-Ali wants to merge 1 commit into
Esma-Ali wants to merge 1 commit into
Conversation
Contributor
|
Excellent work! The provided logs perfectly confirm the bug described in #617: executing the intensive file shuffler loop directly from the QML folder dialog completely locks up the application's main loop.By refactoring this process into an asynchronous QThread and utilizing Qt signals to update the log panel, you successfully preserve UI responsiveness without interrupting the file operations. The layout remains unaffected, and the fix functions perfectly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
This PR fixes issue #617 where clicking Anonymize caused the GUI to freeze after selecting a folder.
Root cause
The file shuffler was being executed synchronously from the QML folder dialog flow, which blocked the main GUI thread.
What changed
QThreadFileShuffler.qmlso it starts the task asynchronously instead of expecting an immediate return valueResult
#617