Skip to content

Fix: Drone Tab crash on startup and takeoff without connection #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SgtBen22 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Drone Tab crash on startup and takeoff without connection #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions GUI5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ def __init__(self):
self.tello = Tello(retry_count=1)
except Exception as e:
print(f"Warning: Failed to initialize Tello drone: {e}")
self.tello = None
self.logMessage.emit(f"Warning: Failed to initialize Tello drone: {e}")

# Initialize camera controller with tello instance
Expand Down Expand Up @@ -206,13 +207,18 @@ def _drone_loop(self):
finally:
self.cmd_queue.task_done()

@Slot()
def takeoff(self):
self.tello.takeoff()
self.connected = True
self.is_flying = True
self.hover_timer.start(200) #every 200 ms, the hover callback will be invoked
self.logMessage.emit("Hovering")
@Slot()
def takeoff(self):
if not self.connected or self.tello is None:
self.logMessage.emit("Drone not connected. Please connect first.")
self.flight_log.insert(0, "Takeoff failed: Drone not connected")
self.flightLogUpdated.emit(self.flight_log)
return
self.tello.takeoff()
self.connected = True
self.is_flying = True
self.hover_timer.start(200) #every 200 ms, the hover callback will be invoked
self.logMessage.emit("Hovering")

def hover_callback(self):
if self.is_flying:
Expand Down