Expedition map: center node icons inside foreignObject - #232
Merged
Conversation
Font-icon glyphs (ra-footprint, ra-aura, ra-broadsword…) inherit their font baseline + line-height inside foreignObject, so they slipped ~1px south of the circle center on mobile. Verified via DOM rects: icon center used to land at circle.y + 0.92px. Wrap the <Icon> in a flex centerer div inside the foreignObject. After fix, icon center matches circle center to floating-point precision (dy ≈ 1.5e-5). Works for both font icons (RPG-Awesome) and SVG-mask icons in the same set. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font-icon glyphs inherit font baseline + line-height inside foreignObject and slip ~1px south of the circle center. Wrap the in a flex-centering div. Verified: icon center matches circle center to floating-point precision after fix.