Skip to content

Conversation

@chemiskyy
Copy link
Member

  • Add exception for eig_sym function of armadillo : exception_eig_sym
  • Add throw exception for all functions that are using eig_sym
  • optimize tensorial product

@chemiskyy chemiskyy requested a review from Copilot May 6, 2025 11:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces exception handling for Armadillo’s eig_sym function by throwing simcoon-specific exceptions, adds tests for these exception triggers, and refactors various source and header files to use updated simcoon constants and improve documentation.

  • Replace sim_iota with simcoon::iota in ODF.cpp.
  • Add try/catch wrapping around inv and eig_sym calls in objective_rates.cpp and test files.
  • Update documentation and constants (e.g., sim_pi to simcoon::pi) across header files.

Reviewed Changes

Copilot reviewed 93 out of 94 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
software/ODF.cpp Uses simcoon::iota in linspace call for consistency.
simcoon-python-builder/test/exception_test/*.py/cpp Adds and tests exception handling for eig_sym failures.
simcoon-python-builder/src/python_wrappers/*.cpp Registers new simcoon exceptions with pybind11 and wraps functions in try/catch.
include/simcoon/parameter.hpp, exception.hpp, and others Refactors constants and updates documentation for clarity and consistency.
Various documentation files Updates parameter descriptions and usage examples to reflect new simcoon constants.
Files not reviewed (1)
  • simcoon-python-builder/CMakeLists.txt: Language not supported

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@chemiskyy chemiskyy closed this Jul 11, 2025
@chemiskyy chemiskyy reopened this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants