fix: Apply per-die modifiers before group success/failure checks - #7
Open
scooper4711 wants to merge 1 commit into
Open
fix: Apply per-die modifiers before group success/failure checks#7scooper4711 wants to merge 1 commit into
scooper4711 wants to merge 1 commit into
Conversation
When a grouped dice expression like {3d10+9}>10 is rolled, the +9
modifier must be applied to each individual die value before the
success/failure target check. Previously the modifier was only applied
to the group total, causing success counts to be evaluated against
raw die faces instead of (die + modifier).
Fixes 3d-dice#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a grouped dice expression like {3d10+9}>10 is rolled, the +9 modifier must be applied to each individual die value before the success/failure target check. Previously the modifier was only applied to the group total, causing success counts to be evaluated against raw die faces instead of (die + modifier).
Fixes #1