fix(release): fail-closed checksum verify and gate uploads - #10
Merged
Conversation
Require non-empty SHA256SUMS and SHA512SUMS, run shasum -c without masking exit status, add composite release-verify, and make both release-upload and release-upload-provenance depend on it. Wire a hermetic checksum regression into precommit (the gate CI runs). Generated by Grok 4.5 (https://x.ai) running Grok Build (https://x.ai) under supervision of @3leapsdave Co-Authored-By: Grok 4.5 <noreply@3leaps.net> Role: devlead Committer-of-Record: Dave Thompson <dave.thompson@3leaps.net> [@3leapsdave]
Format the checksum regression script with shfmt -i 4 -ci and clarify public docs that only the maintainer Make upload targets are gated by release-verify; tag CI may still publish unsigned archives first. Generated by Grok 4.5 (https://x.ai) running Grok Build (https://x.ai) under supervision of @3leapsdave Co-Authored-By: Grok 4.5 <noreply@3leaps.net> Role: devlead Committer-of-Record: Dave Thompson <dave.thompson@3leaps.net> [@3leapsdave]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release-path automation hardening for 0.4.10:
make release-verify-checksums(non-empty manifests; bareshasum -c)make release-verify(checksums + signatures + keys)release-uploadandrelease-upload-provenancedepend on full verificationmake precommit(the gate CI runs)Tag CI may still publish unsigned platform archives and the install script before the manual sign/verify phase; this change gates the maintainer Make upload recipes only.
Generated by Grok 4.5 (https://x.ai) running Grok Build (https://x.ai) under supervision of @3leapsdave
Co-Authored-By: Grok 4.5 noreply@3leaps.net
Role: devlead
Committer-of-Record: Dave Thompson dave.thompson@3leaps.net [@3leapsdave]