ci: pin install-script smoke to signed N-1 tag - #8
Merged
Conversation
Main CI dry-run followed latest and 404'd when a just-tagged release still lacked platform archives. Read SFETCH_VERSION from the Makefile and pass --tag plus --require-minisign so the smoke test only exercises a fully signed published cut. Role: devlead Generated by Grok 4.5 (https://x.ai) running Grok Build (https://x.ai) under supervision of [@3leapsdave](https://github.com/3leapsdave) Co-Authored-By: Grok 4.5 <noreply@3leaps.net> Committer-of-Record: Dave Thompson <dave@3leaps.net> [@3leapsdave]
Shell-parsing Makefile assignment is brittle across assignment forms and version shapes. Add print-sfetch-version and have CI call make so the pin is expanded by make for any patch/minor/major tag value. Role: devlead Generated by Grok 4.5 (https://x.ai) running Grok Build (https://x.ai) under supervision of [@3leapsdave](https://github.com/3leapsdave) Co-Authored-By: Grok 4.5 <noreply@3leaps.net> Committer-of-Record: Dave Thompson <dave@3leaps.net> [@3leapsdave]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes main CI failing after each release tag:
install-sfetch.sh --dry-runwas following latest, which can resolve to a just-created release before platform archives finish uploading (HTTP 404).Change
SFETCH_VERSIONfrom the Makefile (N-1 fully signed pin) and runs:bash scripts/install-sfetch.sh --dry-run --tag <pin> --require-minisignSFETCH_VERSIONis shared by bootstrap and this smoke test; advance after each signed publish.