Repository navigation
ci: restore workflow hardening, prep clean 0.1.5 - #18
Merged
Merged
Conversation
The OIDC switch was made against an older version of the file and dropped the SHA pins, permissions default, --ignore-scripts and Node 24 along with it. Trusted publishing itself is unchanged. allowUpdates stops a release created by hand for the tag from failing the job with a 422, which is what happened on v0.1.4. Refs #4, #16
npm publish warned it had auto-corrected this. Result of npm pkg fix. Refs #9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for a clean 0.1.5. Refs #4, #16.
Workflow. The OIDC switch in b848109 was made against an older version of the file, so it also reverted the hardening from #12 — SHA pins,
permissions: {},--ignore-scriptsand Node 24 all went back. Restored here; trusted publishing itself is untouched and works (0.1.2 was published bynpm-oidc-no-reply@github.com).The
npm install -g npm@^11.5step stays even though Node 24 ships npm 11.9. Trusted publishing needs >= 11.5.1 and a release should not depend on what the runner happens to ship.Left on the v4 pins on purpose rather than taking the bumps from #13/#14/#15 — one thing at a time, with two failed releases behind us. Those can go in right after 0.1.5 is out.
allowUpdates: trueon the release step. v0.1.4 failed with422 already_existsbecause a release had been created by hand for the tag; the publish had already succeeded at that point. Without this it happens again.npm pkg fixon the repository url —npm publishwarned it had auto-corrected it.Checked:
npm ci --ignore-scripts && npm run buildon a clean tree.After merge: drop the tags and releases for
v.0.1.3andv0.1.4(neither exists on npm), add release notes forv0.1.2, thennpm version 0.1.5 -m "chore: release %s"and push the tag.