fix(installer): deduplicate shared skill discovery - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer created independent skill copies in directories that OpenCode and pi also discover, so old native copies and backups could shadow a shared update.
Install one canonical copy for Codex, OpenCode and pi, and keep Claude's adapted copy without
name, using its supported directory-name fallback. Add explicit local--migrate --replacemigration for recognized legacy copies, backups and interrupted stages, with preserved originals and rollback. Keep transaction data outside discovery roots, validate physical path aliases, and retain native agent destinations. SSH installs deduplicate compatible targets; migration itself runs locally on the target machine.Incorporates the shared installer/smoke target-resolution idea from #17, fixing smoke checks that still inspected the old pi/OpenCode directories. Keeps the discovery, migration and rollback behavior described above. Prepares version 0.4.1 and its upgrade notes.
Closes #16.
Validation:
npm test: 205 passed, 1 Unix-only test skipped on Windows.npm run check-packagepassed.Model: GPT-6
Harness: Codex